New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#882 Create a shared project #1089

Merged

VanCongBang merged 11 commits into main from #882-create-a-shared-project

Oct 1, 2024

Contributor

nashtech-huyphamphu commented Sep 26, 2024

Refactor to use classes from common-library for remaining modules.

github-actions bot commented Sep 26, 2024

Storefront BFF Coverage Report

Overall Project	NaN% `NaN%`	🍏

There is no coverage information present for the Files changed

github-actions bot commented Sep 26, 2024 •

edited

Loading

Payment Coverage Report

Overall Project	77.28%	❌

File	Coverage
PaymentProviderService.java	100%	🍏

github-actions bot commented Sep 26, 2024 •

edited

Loading

Order Coverage Report

Overall Project	79.77%	❌

File	Coverage
OrderService.java	89.96%	🍏
AuthenticationUtils.java	58.33%	🍏
CheckoutService.java	30.09%	🍏

github-actions bot commented Sep 26, 2024 •

edited

Loading

Search Coverage Report

Overall Project	92.79%	🍏

File	Coverage
ProductSyncDataService.java	100%	🍏

github-actions bot commented Sep 26, 2024 •

edited

Loading

Payment Paypal Coverage Report

Overall Project	84.47%	🍏

File	Coverage
AuthenticationUtils.java	100%	🍏

github-actions bot commented Sep 26, 2024 •

edited

Loading

Media Coverage Report

Overall Project	87.19%	🍏

File	Coverage
MediaController.java	100%	🍏
MediaServiceImpl.java	98.08%	🍏

github-actions bot commented Sep 26, 2024 •

edited

Loading

Webhook Coverage Report

Overall Project	79.19% `-5.52%`	❌
Files changed	57.26%	❌

File	Coverage
NotificationStatus.java	100%	🍏
AbstractWebhookEventNotificationService.java	100%	🍏
WebhookController.java	100%	🍏
WebhookMapper.java	95.24%	🍏
WebhookService.java	90.98% `-9.02%`	❌
OrderEventService.java	88.46% `-11.54%`	❌
ProductEventService.java	82.54% `-17.46%`	❌
MessagesUtils.java	0% `-4.35%`	❌
WebhookApi.java	0% `-13.95%`	❌

github-actions bot commented Sep 26, 2024 •

edited

Loading

Promotion Coverage Report

Overall Project	83.84%	🍏

File	Coverage
PromotionService.java	98.42%	🍏

github-actions bot commented Sep 26, 2024 •

edited

Loading

Rating Coverage Report

Overall Project	82.32%	🍏

File	Coverage
RatingService.java	100%	🍏
AuthenticationUtils.java	73.68%	🍏

github-actions bot commented Sep 26, 2024 •

edited

Loading

Tax Coverage Report

Overall Project	89.71%	🍏

File	Coverage
TaxClassService.java	100%	🍏
TaxRateService.java	100%	🍏

nashtech-huyphamphu added 7 commits

September 30, 2024 10:57


          #882 Create a shared project

5ec3e54


          #882 Create a shared project

6fae1ce


          #882 Create a shared project

dd29375


          #882 Create a shared project

99c6f06


          #882 Create a shared project

ae2dd69


          #882 Create a shared project

073266b


          #882 Create a shared project

0a795ef

nashtech-huyphamphu force-pushed the #882-create-a-shared-project branch from ce89c95 to 0a795ef Compare

September 30, 2024 03:59

nashtech-huyphamphu added 4 commits

September 30, 2024 12:10


          #882 Create a shared project

4add160


          #882 Create a shared project


          #882 Create a shared project

e96ce42


          #882 Create a shared project

4dbba5b

sonarcloud bot commented Oct 1, 2024

Quality Gate passed for 'storefront-bff'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Oct 1, 2024

Quality Gate passed for 'sampledata'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Oct 1, 2024

Quality Gate passed for 'payment-paypal'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Oct 1, 2024

Quality Gate passed for 'webhook'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Oct 1, 2024

Quality Gate passed for 'media'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Oct 1, 2024

Quality Gate passed for 'promotion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Oct 1, 2024

Quality Gate passed for 'rating'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Oct 1, 2024

Quality Gate passed for 'order'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Oct 1, 2024

Quality Gate passed for 'search'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Oct 1, 2024

Quality Gate passed for 'payment'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Oct 1, 2024

Quality Gate passed for 'tax'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nashtech-tuannguyenhuu1 approved these changes

View reviewed changes

VanCongBang approved these changes

View reviewed changes

VanCongBang merged commit e5da0c4 into main

35 checks passed

VanCongBang deleted the #882-create-a-shared-project branch

October 1, 2024 03:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet