#829 - Config common library and add test for product, cart,... for checking #1057

khanhduzz · 2024-09-23T02:03:13Z

Update

Update the version configuration in the common-library module to ensure compatibility with other modules
Enhance test coverage by add some integration tests into the product
Add some unit tests in the cart module to verify the functionality of the common library

Now, to build a specific module in local with maven, instead of normal use:

mvn clean install -f module

use this command to run and build all the necessary module:

 mvn clean install -pl module -am

github-actions · 2024-09-23T04:02:35Z

Product Coverage Report

Overall Project	72.11%	❌

File	Coverage
BrandService.java	97.25%	🍏

github-actions · 2024-09-23T06:41:23Z

Cart Coverage Report

Overall Project	86.08%	🍏

There is no coverage information present for the Files changed

khanhduzz · 2024-09-24T02:47:25Z

After searching about testcontainer.reuse, I got some information:
First, the testcontainers reuse need to create a file inside system, not inside project, I have tried create file with name like this:

testcontainers.properties
or
.testcontainers.properties

inside test/resources, root of product module or root of yas with the content:

testcontainers.reuse.enable=true

I also tried to add the TESTCONTAINERS_REUSE_ENABLE=true inside the .env file
But the log always show reuse was request but environment does not support:

Then, I tried to create a file .testcontainers.properties inside local system and run test, it works and re-use the test container, and I found this blog about test container:

https://blog.dkwr.de/development/2023-08-18-testcontainers-spring-boot-3/#:~:text=The%20setting.withReuse%28true%29%20keeps%20the%20container%20alive%20between%20test,~%2F.testcontainers.properties%20file%20and%20add%20the%20following%20line%3A%20testcontainers.reuse.enable%3Dtrue

https://java.testcontainers.org/features/reuse/

So, this is the first way to config test container for re-use.

The second way, I try to refactor the previous IT inside product module, add this config to all the IT class, to let spring re-use test container when run:

And the result is good here, when I run: mvn clean install -pl product -am:

minhtridn2001 · 2024-09-24T03:00:19Z

cart/src/test/java/com/yas/cart/service/CartServiceTest.java

+        cartRepository = mock(CartRepository.class);
+        cartItemRepository = mock(CartItemRepository.class);
+        productService = mock(ProductService.class);
+        cartService = new CartService(cartRepository, cartItemRepository, productService);


Utilize @Injectmocks and @mock annotation instead of using mock() explicitly.

I’ve updated the code to utilize @Injectmocks and @mock annotations. Please take a review, thank you.

minhtridn2001 · 2024-09-24T03:00:26Z

cart/src/test/java/com/yas/cart/service/CartServiceTest.java

+    }
+
+    @Test
+    void testAddToCart_ProductNotFound() {


The method name should describe the condition and expected outcome as well.

minhtridn2001 · 2024-09-24T03:01:23Z

cart/src/test/java/com/yas/cart/service/CartServiceTest.java

+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+class CartServiceTest {


Why there are no happy cases in this test class?

This cart test class is designed solely to test the functionality of the common library. Since the cart module already has high code coverage, I’ve only added a few cases to trigger the pipeline

minhtridn2001 · 2024-09-24T03:13:14Z

product/src/it/java/com/yas/product/controller/ProductControllerIT.java

+        category.setName("Category");
+        categoryRepository.save(category);
+
+        productOne = Product.builder()


Extract test data object creations into another helper class to increase the readability of insertTestData()

I’ve separated it. Please review it. Thank you!

minhtridn2001 · 2024-09-24T03:14:06Z

product/src/it/java/com/yas/product/controller/ProductControllerIT.java

+        productRelatedRepository.deleteAll();
+        productOptionRepository.deleteAll();
+        productImageRepository.deleteAll();
+        productOptionRepository.deleteAll();


productOptionRepository.deleteAll(); is called twice.

minhtridn2001 · 2024-09-24T03:17:23Z

product/src/it/java/com/yas/product/controller/ProductControllerIT.java

+
+    @Test
+    void test_getProductFeature_shouldReturnProductList() {
+        given(getRequestSpecification())


getRequestSpecification()) .auth().oauth2(getAccessToken("admin", "admin"))

Extract this code into a method to avoid repetition code

minhtridn2001 · 2024-09-24T03:20:03Z

product/src/it/java/com/yas/product/controller/ProductControllerIT.java

+    private static final String PRODUCT_STOREFRONT_URL = "/v1/storefront/products";
+
+    @BeforeEach
+    public void insertTestData() {


This method creates a complex data setup. Consider creating specific test data for each test instead of setup everything for all tests.

minhtridn2001

Hi @khanhduzz,
I have some suggestions for enhancement. Please take a look.
Thanks!

sonarcloud · 2024-09-24T06:58:15Z

Quality Gate passed for 'yas'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-09-24T06:58:28Z

Quality Gate passed for 'product'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

minhtridn2001 · 2024-09-24T07:35:46Z

cart/src/test/java/com/yas/cart/service/CartServiceTest.java

+
+    @BeforeEach
+    void setUp() {
+        MockitoAnnotations.openMocks(this);


@RunWith(MockitoJUnitRunner.class) already handle the mock initialization. You don't need to call openMocks manually.

add test for product

c57d787

khanhduzz changed the title ~~add test for product~~ #829 - Add test for product Sep 23, 2024

test fix common library

5d2b523

khanhduzz added 3 commits September 23, 2024 11:17

add component scan common library in integration test

ed1404f

component scan brand test

db6bccf

add test in cart module for testing common library

882be1b

khanhduzz changed the title ~~#829 - Add test for product~~ #829 - Config common library and add test for product, cart,... for checking Sep 23, 2024

fix sonar cloud

9b93352

khanhduzz linked an issue Sep 23, 2024 that may be closed by this pull request

Add integration test for product services #829

Closed

khanhduzz marked this pull request as ready for review September 23, 2024 08:41

khanhduzz requested review from khanhtrand and nashtech-huyphamphu September 23, 2024 08:41

fix checkstyle

09cd3d6

khanhduzz requested a review from VanCongBang September 23, 2024 08:58

VanCongBang approved these changes Sep 23, 2024

View reviewed changes

khanhduzz removed the request for review from VanCongBang September 23, 2024 09:02

remove component scan in IT

83a67ad

minhtridn2001 reviewed Sep 24, 2024

View reviewed changes

minhtridn2001 requested changes Sep 24, 2024

View reviewed changes

refactor product IT with media IT and cart test

1904513

khanhduzz closed this Sep 24, 2024

khanhduzz reopened this Sep 24, 2024

nguyenvanhadncntt approved these changes Sep 24, 2024

View reviewed changes

khanhduzz requested a review from minhtridn2001 September 24, 2024 07:10

minhtridn2001 reviewed Sep 24, 2024

View reviewed changes

minhtridn2001 approved these changes Sep 24, 2024

View reviewed changes

khanhtrand merged commit a5e2a39 into main Sep 24, 2024
15 checks passed

khanhtrand deleted the #829-product-test branch September 24, 2024 07:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#829 - Config common library and add test for product, cart,... for checking #1057

#829 - Config common library and add test for product, cart,... for checking #1057

khanhduzz commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024

khanhduzz commented Sep 24, 2024 •

edited

Loading

minhtridn2001 Sep 24, 2024

khanhduzz Sep 24, 2024

minhtridn2001 Sep 24, 2024 •

edited

Loading

minhtridn2001 Sep 24, 2024

khanhduzz Sep 24, 2024

minhtridn2001 Sep 24, 2024

khanhduzz Sep 24, 2024

minhtridn2001 Sep 24, 2024

minhtridn2001 Sep 24, 2024

minhtridn2001 Sep 24, 2024

minhtridn2001 left a comment

sonarcloud bot commented Sep 24, 2024

sonarcloud bot commented Sep 24, 2024

minhtridn2001 Sep 24, 2024

#829 - Config common library and add test for product, cart,... for checking #1057

#829 - Config common library and add test for product, cart,... for checking #1057

Conversation

khanhduzz commented Sep 23, 2024 • edited Loading

Update

Now, to build a specific module in local with maven, instead of normal use:

github-actions bot commented Sep 23, 2024 • edited Loading

Product Coverage Report

github-actions bot commented Sep 23, 2024

Cart Coverage Report

khanhduzz commented Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minhtridn2001 Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minhtridn2001 left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Sep 24, 2024

Quality Gate passed for 'yas'

sonarcloud bot commented Sep 24, 2024

Quality Gate passed for 'product'

Choose a reason for hiding this comment

khanhduzz commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

khanhduzz commented Sep 24, 2024 •

edited

Loading

minhtridn2001 Sep 24, 2024 •

edited

Loading