Simplify payment flow

nashtech-garage · Sep 26, 2024 · d0a80fa · d0a80fa
1 parent 97d3382
commit d0a80fa
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 5 deletions.
diff --git a/docs/design/order-flows/diagrams/payment.seq-1.puml b/docs/design/order-flows/diagrams/payment.seq-1.puml
@@ -29,9 +29,8 @@ activate storefront #fdf2e9
     order_service -> promotion_service: POST /promotion/promotions/{PROMOCODE}/usage {checkout_id, state: APPLIED}
     activate promotion_service #8af1f0
     promotion_service --> order_service: 201 CREATED 
-    alt #f1948a "Fail to apply"
-    promotion_service --> order_service: 422 UNPROCESSABLE CONTENT {ERROR_CODE: PROMOCODE_RAN_OUT| PROMOCODE_EXPIRED}
     deactivate promotion_service
+    alt #f1948a "Fail to apply"
     order_service --> checkout: Remove promo code
     order_service --> storefront: 400 BAD REQUEST {ERROR_CODE: PROMOCODE_RAN_OUT| PROMOCODE_EXPIRED}
     storefront --> customer:  PROMOCODE ran out of usage| Promocode expired

diff --git a/docs/design/order-flows/diagrams/payment.seq.puml b/docs/design/order-flows/diagrams/payment.seq.puml
@@ -31,9 +31,8 @@ activate storefront #fdf2e9
     order_service -> promotion_service: POST /promotion/promotions/{PROMOCODE}/usage {checkout_id, state: APPLIED}
     activate promotion_service #8af1f0
     promotion_service --> order_service: 201 CREATED 
-    alt #f1948a "Fail to apply"
-    promotion_service --> order_service: 422 UNPROCESSABLE CONTENT {ERROR_CODE: PROMOCODE_RAN_OUT| PROMOCODE_EXPIRED}
     deactivate promotion_service
+    alt #f1948a "Fail to apply"
     order_service --> checkout: Remove promo code
     order_service --> storefront: 400 BAD REQUEST {ERROR_CODE: PROMOCODE_RAN_OUT| PROMOCODE_EXPIRED}
     storefront --> customer:  PROMOCODE ran out of usage| Promocode expired

diff --git a/docs/design/order-flows/imgs/Payment Flow Sub 1.png b/docs/design/order-flows/imgs/Payment Flow Sub 1.png
diff --git a/docs/design/order-flows/imgs/Payment Flow.png b/docs/design/order-flows/imgs/Payment Flow.png
diff --git a/docs/design/order-flows/imgs/Payment Flow.svg b/docs/design/order-flows/imgs/Payment Flow.svg