[Product] Fix error when remove images when create, update product, c…

…ategory (#1015) * fix remove images when update product * fix create, update category image * restore product service with checkstyle
nashtech-garage · Sep 11, 2024 · 46b0258 · 46b0258
1 parent 56fda46
commit 46b0258
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/backoffice/modules/catalog/components/CategoryImage.tsx b/backoffice/modules/catalog/components/CategoryImage.tsx
@@ -50,6 +50,8 @@ const CategoryImage = ({ id, image, setValue }: CategoryImageProps) => {
 
   const onDeleteImage = () => {
     setImageURL(null);
+    setValue('categoryImage', undefined);
+    setValue('imageId', undefined);
   };
 
   return (

diff --git a/backoffice/pages/catalog/categories/[id]/edit.tsx b/backoffice/pages/catalog/categories/[id]/edit.tsx
@@ -147,6 +147,7 @@ const CategoryEdit: NextPage = () => {
 
   const onDeleteImage = () => {
     setCategoryImage(null);
+    setImageId(undefined);
   };
 
   return (

diff --git a/product/src/main/java/com/yas/product/repository/ProductImageRepository.java b/product/src/main/java/com/yas/product/repository/ProductImageRepository.java
@@ -3,9 +3,18 @@
 import com.yas.product.model.ProductImage;
 import java.util.List;
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.data.jpa.repository.Modifying;
+import org.springframework.data.jpa.repository.Query;
 import org.springframework.stereotype.Repository;
 
 @Repository
 public interface ProductImageRepository extends JpaRepository<ProductImage, Long> {
+
+    @Modifying
+    @Query("DELETE FROM ProductImage p WHERE p.product.id = :productId AND p.imageId IN :imageIds")
     void deleteByImageIdInAndProductId(List<Long> imageIds, Long productId);
+
+    @Modifying
+    @Query("DELETE FROM ProductImage p WHERE p.product.id = :productId")
+    void deleteByProductId(Long productId);
 }
diff --git a/product/src/main/java/com/yas/product/service/ProductService.java b/product/src/main/java/com/yas/product/service/ProductService.java
@@ -536,18 +536,19 @@ private static void setValuesForVariantExisting(
     public List<ProductImage> setProductImages(List<Long> imageMediaIds, Product product) {
         List<ProductImage> productImages = new ArrayList<>();
         if (CollectionUtils.isEmpty(imageMediaIds)) {
+            productImageRepository.deleteByProductId(product.getId());
             return productImages;
         }
         if (product.getProductImages() == null) {
             productImages = imageMediaIds.stream()
-                    .map(id -> ProductImage.builder().imageId(id).product(product).build()).toList();
+                .map(id -> ProductImage.builder().imageId(id).product(product).build()).toList();
         } else {
             List<Long> productImageIds = product.getProductImages().stream().map(ProductImage::getImageId).toList();
             List<Long> newImageIds = imageMediaIds.stream().filter(id -> !productImageIds.contains(id)).toList();
             List<Long> deletedImageIds = productImageIds.stream().filter(id -> !imageMediaIds.contains(id)).toList();
             if (CollectionUtils.isNotEmpty(newImageIds)) {
                 productImages = newImageIds.stream()
-                        .map(id -> ProductImage.builder().imageId(id).product(product).build()).toList();
+                    .map(id -> ProductImage.builder().imageId(id).product(product).build()).toList();
             }
             if (CollectionUtils.isNotEmpty(deletedImageIds)) {
                 productImageRepository.deleteByImageIdInAndProductId(deletedImageIds, product.getId());