MMT-3891: Existing country should be displayed in draft form.

[htranho]

Overview

What is the feature?

Existing country in address form doesn't displayed in the draft form and only short form of country names are written to json.

What is the Solution?

Issues were that Country selector:

1. When it writes to json, the short form of the country name is written ('US' instead of 'United States', 'TZ' instead of 'Tanzania, United Republic of')
2. When importing into the form (Edit a Collection), values like 'United States' in address field 'Country' will not be displayed in the form.

Those issues are fixed:

1. Long form of country name is to be written to json.
2. When edit an existing record, both short and long form of country name will be read and displayed.

What areas of the application does this impact?

List impacted areas.

Country selector

Reproduction steps

1. Create a new draft, long form of country name is written out to json.
2. Import an existing collection with 'US' in address field, that should work.

Attachments

N/A

Checklist

• I have added automated tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (e7e5afa) to head (d2f04f0).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1307   +/-   ##
=======================================
  Coverage   97.65%   97.66%           
=======================================
  Files         362      362           
  Lines        5584     5601   +17     
  Branches     1172     1177    +5     
=======================================
+ Hits         5453     5470   +17     
  Misses        130      130           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cgokey]

did you confirm with Erich or someone that the long form is what is expected in the json?

[htranho]

Only Scott replied to my question (Asked Eric, Scott and Tyler): 'I am thinking long form. Do you all agree?'

[htranho]

Tyler also think that long form makes sense

[mandyparson]

Need to figure out snyk issue