MMT-3418: Fixed the tests

nasa · Jan 4, 2024 · 7a3c2fd · 7a3c2fd
1 parent f2ac653
commit 7a3c2fd
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 9 deletions.
diff --git a/static/src/js/components/CustomTextWidget/__tests__/CustomTextWidget.test.js b/static/src/js/components/CustomTextWidget/__tests__/CustomTextWidget.test.js
@@ -185,8 +185,8 @@ describe('CustomTextWidget', () => {
  describe('when the input is a number field', () => {
  test('renders a number field', () => {
  setup({
- uiSchema: {
- 'ui:type': 'number'
+ schema: {
+ type: 'number'
  }
  })
 

diff --git a/static/src/js/components/GridRow/__tests__/GridRow.test.js b/static/src/js/components/GridRow/__tests__/GridRow.test.js
@@ -203,7 +203,11 @@ describe('when there is a group title', () => {
  })
 
  expect(GridGroupedSinglePanel).toHaveBeenCalledTimes(1)
- expect(GridGroupedSinglePanel).toHaveBeenCalledWith(props, {})
+ expect(GridGroupedSinglePanel).toHaveBeenCalledWith(expect.objectContaining({
+ idSchema: props.idSchema,
+ onChange: props.onChange,
+ schema: props.schema
+ }), {})
  })
  })
 

diff --git a/static/src/js/components/OneOfField/OneOfField.jsx b/static/src/js/components/OneOfField/OneOfField.jsx
@@ -278,12 +278,16 @@ class OneOfField extends React.Component {
 OneOfField.defaultProps = {
  baseType: null,
  errorSchema: null,
- formData: {},
- uiSchema: {}
+ formData: undefined,
+ uiSchema: undefined
 }
 
 OneOfField.propTypes = {
- formData: PropTypes.shape({}),
+ formData: PropTypes.oneOfType([
+ PropTypes.string,
+ PropTypes.number,
+ PropTypes.shape({})
+ ]),
  options: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
  registry: PropTypes.shape({
  schemaUtils: PropTypes.shape({

diff --git a/static/src/js/utils/__tests__/getUiSchema.test.js b/static/src/js/utils/__tests__/getUiSchema.test.js
@@ -1,5 +1,6 @@
 import serviceUiSchema from '../../schemas/uiSchemas/services'
 import toolsUiSchema from '../../schemas/uiSchemas/tools'
+import variableUiSchema from '../../schemas/uiSchemas/variables'
 import getUiSchema from '../getUiSchema'
 
 describe('getUiSchema', () => {
@@ -15,10 +16,9 @@ describe('getUiSchema', () => {
  })
  })
 
- // TODO MMT-3418
  describe('when the concept type is variable-draft', () => {
- test.skip('returns the UMM-V schema', () => {
- expect(getUiSchema('Variable')).toEqual('Replace with Variable uiSchema')
+ test('returns the UMM-V schema', () => {
+ expect(getUiSchema('Variable')).toEqual(variableUiSchema)
  })
  })
 
@@ -28,4 +28,10 @@ describe('getUiSchema', () => {
  expect(getUiSchema('Collection')).toEqual('Replace with Collection uiSchema')
  })
  })
+
+ describe('when the concept type is not recognized', () => {
+ test('returns null', () => {
+ expect(getUiSchema('bad-draft')).toEqual(null)
+ })
+ })
 })