Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARMONY-1878: Make WKT conversion precision configurable #631

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

ygliuvt
Copy link
Member

@ygliuvt ygliuvt commented Sep 27, 2024

Jira Issue ID

HARMONY-1878, HARMONY-1873

Description

Make WKT conversion precision configurable.
Update /service-image-tag api doc.

Local Test Steps

Verify EDR position and trajectory searches still work.
Verify /service-image-tag API doc looks good.

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

@@ -108,6 +108,8 @@ class HarmonyServerEnv extends HarmonyEnv {
@Min(1)
maxDataOperationCacheSize: number;

wktPrecision: number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You might want to add a constraint that this is a positive number

Copy link
Contributor

@indiejames indiejames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment

@ygliuvt ygliuvt merged commit d4af25d into main Sep 27, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants