-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUMULUS-3890: Address sftp provider multi-part/fastGet concern #3809
base: master
Are you sure you want to change the base?
Changes from all commits
83fd2c8
aa314ee
ae30573
e3de4fb
f195570
e91d941
a9d773b
ee10ed1
c7a2d79
c301ea3
03b9822
5e52bb0
25d28c1
994e877
7554d51
0cdad44
81cecdf
1e773b7
4c2e461
fac41f7
5a63c76
de8f086
926291f
47fa0a3
e9ee557
ef1dacc
67b6145
4fb4a1d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,7 +112,9 @@ export class SftpClient { | |
|
||
log.info(`Downloading ${remoteUrl} to ${localPath}`); | ||
|
||
await this.sftp.fastGet(remotePath, localPath); | ||
await this.sftp.fastGet(remotePath, localPath, { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
concurrency: 0, | ||
}); | ||
|
||
log.info(`Finished downloading ${remoteUrl} to ${localPath}`); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the ticket AC mentions
fastGet use is justified/confirmed as acceptable, and an alternative implementation is made configurable, with fastGet disabled by default.
how would I even make an alternate implementation available? like an option for them to have concurrency if their server can handle it, is there some process.env or other var I can use, a little confused about that