Fix Cumulus Dashboard High Vulnerabilities #1093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjmccoy
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
@efenollal LGTG! Once your permissions error is resolved you can squash merge.
jennyhliu
reviewed
Feb 8, 2023
| @@ -25,6 +25,8 @@ This version of the dashboard requires Cumulus API >= v14.0.0 | |||
| - Added action to list pages to refresh cumulus db connection | |||
| - Updated `git+ssh://git@` to `git+https://` for npm 8.6.0 generated package-lock.json, | |||
| and this is an [known issue](https://github.com/npm/cli/issues/2610) with npm 8.6.0 | |||
| - **CUMULUS-3107** | |||
| - Added d3-dag dependency to replace dagre-d3 | |||
There was a problem hiding this comment.
degre-d3 isn't replaced in this PR?
There was a problem hiding this comment.
Please move CUMULUS-3107 to unreleased section.
There was a problem hiding this comment.
Also update PR title to be more specific, and it's better to include ticket number
There was a problem hiding this comment.
The d3-dag dependency was added to replace dagre-d3 in the ticket https://bugs.earthdata.nasa.gov/browse/CUMULUS-3184
There was a problem hiding this comment.
Ok if this work is not done, we should remove this entry.
There was a problem hiding this comment.
The Unreleased section is on the top of the changelog
## [Unreleased]
### Changed
- **CUMULUS-3107**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates package.json d3 dependency to latest version (7.8.2).
https://bugs.earthdata.nasa.gov/browse/CUMULUS-3107
Changes
d3 dependency updated to latest version
PR Checklist