Fix #455, Convert suitable 0/1 variables to bool type
#456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -689,7 +689,7 @@ | |||
| if (success && txn->state_data.receive.r2.rx_crc_calc_bytes == txn->fsize) | |||
| { | |||
| /* all bytes calculated, so now check */ | |||
| if (!CF_CFDP_R_CheckCrc(txn, txn->state_data.receive.r2.eof_crc)) | |||
| if (CF_CFDP_R_CheckCrc(txn, txn->state_data.receive.r2.eof_crc) == CFE_SUCCESS) | |||
Check warning
Code scanning / CodeQL
Side effect in a Boolean expression Warning
| @@ -1586,7 +1586,7 @@ | |||
| * See description in cf_cfdp.h for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| void CF_CFDP_ResetTransaction(CF_Transaction_t *txn, int keep_history) | |||
| void CF_CFDP_ResetTransaction(CF_Transaction_t *txn, bool keep_history) | |||
Check notice
Code scanning / CodeQL
Long function without assertion Note
| @@ -981,14 +981,14 @@ | |||
| * See description in cf_cmd.h for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| void CF_GetSetParamCmd(uint8 is_set, CF_GetSet_ValueID_t param_id, uint32 value, uint8 chan_num) | |||
| void CF_GetSetParamCmd(bool is_set, CF_GetSet_ValueID_t param_id, uint32 value, uint8 chan_num) | |||
Check notice
Code scanning / CodeQL
Long function without assertion Note
| @@ -1586,7 +1586,7 @@ | |||
| * See description in cf_cfdp.h for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| void CF_CFDP_ResetTransaction(CF_Transaction_t *txn, int keep_history) | |||
| void CF_CFDP_ResetTransaction(CF_Transaction_t *txn, bool keep_history) | |||
Check notice
Code scanning / CodeQL
Function too long Note
| @@ -981,14 +981,14 @@ | |||
| * See description in cf_cmd.h for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| void CF_GetSetParamCmd(uint8 is_set, CF_GetSet_ValueID_t param_id, uint32 value, uint8 chan_num) | |||
| void CF_GetSetParamCmd(bool is_set, CF_GetSet_ValueID_t param_id, uint32 value, uint8 chan_num) | |||
Check notice
Code scanning / CodeQL
Function too long Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
0/1variables tobooltype #455intvariables being used to represent boolean truth values (on/off, true/false) to use the actualbooltype - improving the clarity of the code.incfolderTesting performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
Effectively no change to behavior (these
intvariables were already being used as boolean truth values).System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt