-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds synonyms moderation front end #2538
base: main
Are you sure you want to change the base?
Conversation
When you delete synonyms, does it double check you meant to delete them? If not, it would be good to do so. |
It does not currently, but that is definitely something I can add in! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2538 +/- ##
========================================
+ Coverage 6.08% 6.23% +0.15%
========================================
Files 164 167 +3
Lines 4077 4216 +139
Branches 450 466 +16
========================================
+ Hits 248 263 +15
- Misses 3827 3951 +124
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything in the action functions that checks that the user is authorized.
app/routes/circulars._archive._index/PaginationSelectionFooter.tsx
Outdated
Show resolved
Hide resolved
app/routes/circulars._archive._index/PaginationSelectionFooter.tsx
Outdated
Show resolved
Hide resolved
@@ -40,10 +33,10 @@ import { | |||
putVersion, | |||
search, | |||
} from '../circulars/circulars.server' | |||
import CircularPagination from './CircularPagination' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module is unused now, isn't it? Please refactor to eliminate dead code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean here? It is used. I moved it into components>pagination>GCNPagination.tsx and it is used in the PaginationFooter which is also moved to that same directory.
3149fdc
to
8a67744
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this took me so long to get to. There are some merge conflicts. Would you please rebase from main?
Squashing your existing commits before rebasing might make it easier.
Description
This is the front end for the moderation portion of synonyms (not the circular index grouped by synonyms, but the ability to create, put, delete the synonyms themselves). It is behind both a feature flag and a moderator check. The majority of the code is behind a feature flag and moderation gate, but I did create a component for pagination to reduce redundancy so I could reuse it for this work. In order to do that I had to update the circulars index page as well. That portion is NOT behind a feature flag.
Related Issue(s)
Resolves #2116
Testing
This is the moderation index with pagination. Links for each group are to the detail page
This is the detail page for a synonym group. The button to save is disabled because no additional eventIds have been added. It is enabled when a new eventId is added.
This is the error shown if you enter an eventId that doesn't exist.
This is the create view with no eventIds added.
This is the same view with eventIds added.
This is the error shown when you try to create a synonym group with an invalid eventId