Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Semantic Search #1688

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Implement Semantic Search #1688

wants to merge 7 commits into from

Conversation

ronitagarwala01
Copy link

@ronitagarwala01 ronitagarwala01 commented Nov 21, 2023 •
edited
Loading

Implement Semantic Search in circulars.server.ts. Add openSearchApi.js module for making API calls to OpenSearch cluster

tylerbarna
tylerbarna suggested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@tylerbarna tylerbarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think openSearchApi.js and openSearchAPI.js are duplicates

openSearchApi.js Outdated Show resolved Hide resolved
lpsinger
lpsinger reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an experiment, would you please try writing the collection of API calls as an Architect deploy.end plugin in this project, rather than using the openSearchApi.js file? I'd like to see what that looks like.

tylerbarna
tylerbarna reviewed Dec 4, 2023
View reviewed changes
app.arc Outdated Show resolved Hide resolved
@ronitagarwala01 ronitagarwala01 force-pushed the publicBranch branch 2 times, most recently from 31addd7 to a370381 Compare December 12, 2023 15:41
@tylerbarna
Copy link
Member

was there anything else we wanted to implement for this PR?

@ronitagarwala01
Copy link
Author

I don't believe so. I want to implement the changes for improving semantic search in another PR.

@lpsinger
Copy link
Member

Please resolve merge conflicts.

@ronitagarwala01
Copy link
Author

Alright. Will do.

ronitagarwala01 and others added 6 commits January 24, 2024 13:47
@ronitagarwala01
Implement Semantic Search in circulars.server.ts
86633ce 
Add postdeploy-search module for making API calls to Search cluster.
@ronitagarwala01
Switch 'architect-plugin-search' dependency source from npm registry …
fbf9fec 
…to its GitHub repository.

Also update package-lock.json to point to new version of 'architect-plugin-search'.
@ronitagarwala01
Create two search query objects. One regular, one NLP.
8a77f55 
Also remove previously added comments.
@ronitagarwala01 @tylerbarna
Restore date filtering to nlp query.
48149fd 
Co-authored-by: Tyler Barna <[email protected]>
@tylerbarna @ronitagarwala01
add NLP feature flag
7ba82fd
@ronitagarwala01
Implement Opensearch's new raw HTTP request API.
d9367b3
@ronitagarwala01 ronitagarwala01 force-pushed the publicBranch branch 2 times, most recently from 708551f to a564ad0 Compare January 24, 2024 20:06
@ronitagarwala01
Fix issues after rebase from main.
168293d 
Sync package.json and package-lock.json.
Fix prettier issues.
@ronitagarwala01
Copy link
Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpsinger lpsinger lpsinger requested changes

@tylerbarna tylerbarna tylerbarna requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronitagarwala01 @tylerbarna @lpsinger