Refactor Docker container launching code #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Courey
reviewed
Jun 25, 2024
Courey
requested changes
Jun 25, 2024
|
you also need to update the import from the index Did you test this change? |
lpsinger
force-pushed
the
refactor-launch-docker
branch
from
b66ab7f to
3e5c9fd
Compare
Courey
reviewed
Jun 25, 2024
lpsinger
added a commit
to lpsinger/architect-plugin-search
that referenced
this pull request
Jun 25, 2024
This should help catch issues like nasa-gcn#43 (comment).
lpsinger
force-pushed
the
refactor-launch-docker
branch
from
3e5c9fd to
490d25d
Compare
lpsinger
added a commit
to lpsinger/architect-plugin-search
that referenced
this pull request
Jun 25, 2024
This should help catch issues like nasa-gcn#43 (comment).
lpsinger
added a commit
that referenced
this pull request
Jun 25, 2024
This should help catch issues like #43 (comment).
I tried adding a unit test (#45) but it doesn't run the sandbox teardown code even for Elasticsearch. Any ideas? |
I meant by running both docker and binary locally at least, but unit tests are good too! Very interesting that it doesn't run the teardown code! I don't have any ideas about why off the top of my head. I can look into why, but it may take a couple of days because I'm in the middle of two other tickets. |
Put subprocess and parent process code in the same file.
lpsinger
force-pushed
the
refactor-launch-docker
branch
from
490d25d to
85064ee
Compare
|
@Courey, please review when you get a chance. |
Courey
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put subprocess and parent process code in the same file.