-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure plugin for calling Search API #20
Conversation
7439adc
to
be574d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use https://www.npmjs.com/package/@nasa-gcn/architect-functions-search?
You mean import the client configured by architect-functions-search? I haven't tried that yet. Let me see if it works. |
Yes, exactly. If the service discovery is working, then architect-functions-search should work too. |
You were right. It works! |
dbc8d6d
to
c10538c
Compare
Please rebase. |
cbc84f8
to
f5e59c1
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document this feature in the README file.
0efc3c3
to
1493ea1
Compare
Updated README.md |
1493ea1
to
7010a6b
Compare
Execute post-deployment API requests in both sandbox mode and production. Add @nasa-gcn/architect-functions-search as dependency.
4aabbea
to
9e18b21
Compare
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Side note: isn't it ironic that we overrode deploy.start
for production but sandbox.end
for local development? Too bad the plugin entry point names are not more consistent.
I know right? It makes it a little confusing imo, but there doesn't seem to be a work around. |
Add function to call a post-deployment search API file defined in gcn.nasa.gov. Allow for execution of REST API calls in both sandbox and production environments.