Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle position changed to remove y-scroll #1305

Merged
merged 4 commits into from
Dec 10, 2023

Conversation

Afterdie
Copy link
Contributor

@Afterdie Afterdie commented Dec 9, 2023

closes #1295

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Afterdie! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@narayan954
Copy link
Owner

Hi @Afterdie these changes are breaking the UI at some places, can you please check and confirm.
image
image
image

@Afterdie
Copy link
Contributor Author

Afterdie commented Dec 9, 2023

@narayan954 look into it, should be working fine now

Copy link

sonarcloud bot commented Dec 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 10a6665 into narayan954:master Dec 10, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary scroll on login page
2 participants