Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature added to accept friend request #1232

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes #953
I have added the feature to accept friend request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@anamika7153
Copy link
Contributor

anamika7153 commented Aug 11, 2023

@Palakkgoyal I wanted to clarify that while I did raise those issues, I hadn't yet had a chance to work on them myself. I understand that you saw the problems and wanted to help, which is commendable. However, I would appreciate it if, in the future, you could coordinate efforts before creating pull requests based on someone else's issues. It was very unprofessional of you to work on the issues before asking. How can you create PRs for other's issues without even asking? I checked that you have your own pending issues. You could have worked on them to get your PRs merged.

@narayan954
Copy link
Owner

narayan954 commented Aug 11, 2023

@Palakkgoyal I wanted to clarify that while I did raise those issues, I hadn't yet had a chance to work on them myself. I understand that you saw the problems and wanted to help, which is commendable. However, I would appreciate it if, in the future, you could coordinate efforts before creating pull requests based on someone else's issues. It was very unprofessional of you to work on the issues before asking. How can you create PRs for other's issues without even asking? I checked that you have your own pending issues. You could have worked on them to get your PRs merged.

agreed! @Palakkgoyal do note this please

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@narayan954 narayan954 merged commit 92ad9f7 into narayan954:master Aug 11, 2023
3 of 4 checks passed
@Palakkgoyal
Copy link
Contributor Author

Palakkgoyal commented Aug 11, 2023

@Palakkgoyal I wanted to clarify that while I did raise those issues, I hadn't yet had a chance to work on them myself. I understand that you saw the problems and wanted to help, which is commendable. However, I would appreciate it if, in the future, you could coordinate efforts before creating pull requests based on someone else's issues. It was very unprofessional of you to work on the issues before asking. How can you create PRs for other's issues without even asking? I checked that you have your own pending issues. You could have worked on them to get your PRs merged.

Yes, @anamika7153 I did a mistake to not claim the issue and I am sorry about that, as the issues that are 2 weeks or more older were stale and anyone could claim them whether they are mine and I only took those issues that were older than 2 weeks. You were creating so many issues and so so many were pending. This is also unprofessional to just create issues, get assigned and leave them. I don't mind if my issues are old, I am not working on them and just creating more and someone else take them. You also should have completed your assigned issues and create new. My only those issue are pending which I don't know how to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Accepting follow requests
3 participants