-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature added to accept friend request #1232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
@Palakkgoyal I wanted to clarify that while I did raise those issues, I hadn't yet had a chance to work on them myself. I understand that you saw the problems and wanted to help, which is commendable. However, I would appreciate it if, in the future, you could coordinate efforts before creating pull requests based on someone else's issues. It was very unprofessional of you to work on the issues before asking. How can you create PRs for other's issues without even asking? I checked that you have your own pending issues. You could have worked on them to get your PRs merged. |
agreed! @Palakkgoyal do note this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Yes, @anamika7153 I did a mistake to not |
This PR closes #953
I have added the feature to accept friend request.