Active styles + different header when expanded #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's cool! Hope that it will be merged. |
compojoom
added a commit
to compojoom/react-native-accordion
that referenced
this pull request
Nov 21, 2016
Cherry picking from 8a801c7 and b6dc745 naoufal#38
|
ping @naoufal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #9.
Not sure about the styles - maybe
style={[this.props.style, this.state.is_visible && this.props.styleOpen]}would be better, so the initial styles gets overwritten?In most cases you just want to change the
backgroundColoror something like that and keep the other styles.