代码性能与风格优化

naosense · Aug 6, 2018 · 366ac28 · 366ac28
1 parent 724f395
commit 366ac28
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/main/java/com/pingao/server/HttpRequestHandler.java b/src/main/java/com/pingao/server/HttpRequestHandler.java
@@ -93,7 +93,7 @@ private static void send100Continue(ChannelHandlerContext ctx) {
 
     @Override
     public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
-        cause.printStackTrace();
+        LOGGER.error("Error occurs cause", cause);
         ctx.close();
     }
 }
diff --git a/src/main/java/com/pingao/server/MarkDownServer.java b/src/main/java/com/pingao/server/MarkDownServer.java
@@ -66,15 +66,15 @@ public ChannelFuture start(int port) {
         future.syncUninterruptibly();
         channel = future.channel();
         isRunning = true;
-        LOGGER.info("Markdown server is running...");
+        LOGGER.info("Markdown server is running on {} ...", channel.localAddress());
         return future;
     }
 
     public void destroy() {
         channel.close();
         channelGroup.close();
         group.shutdownGracefully();
-        LOGGER.info("Server shutdown success");
+        LOGGER.info("Markdown server shutdown success");
     }
 
     public boolean isRunning() {

diff --git a/src/main/java/com/pingao/server/SocketServer.java b/src/main/java/com/pingao/server/SocketServer.java
@@ -44,6 +44,7 @@ public void initChannel(SocketChannel ch) {
                 });
 
             ChannelFuture f = b.bind().sync();
+            LOGGER.info("Socket server is running on {} ...", f.channel().localAddress());
             f.channel().closeFuture().sync();
         } finally {
             group.shutdownGracefully().sync();
@@ -80,9 +81,8 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) {
         }
 
         @Override
-        public void exceptionCaught(ChannelHandlerContext ctx,
-                                    Throwable cause) {
-            cause.printStackTrace();
+        public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
+            LOGGER.error("Error occurs cause", cause);
             ctx.close();
         }
     }