Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the test coverage about DefaultVerifier #227

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Improve the test coverage about DefaultVerifier #227

merged 5 commits into from
Nov 28, 2023

Conversation

aqyuki
Copy link
Contributor

@aqyuki aqyuki commented Nov 28, 2023

I added some tests for DefaultVerifier.
In this PR, I add a test about DefaultVerifer and mock required to test.

I want to be checked this PR and want this PR is merged.
Good Go Life!

@nao1215
Copy link
Owner

nao1215 commented Nov 28, 2023

@aqyuki
Thanks for writing the test.
I will merge this PR. One comment, I think you could have also parallelized the subtests.

Ref. https://www.gopherguides.com/articles/table-driven-testing-in-parallel See Bug Time! section.

@nao1215 nao1215 merged commit 2e9ad0b into nao1215:main Nov 28, 2023
10 checks passed
@aqyuki aqyuki deleted the improve-assert-test-coverage branch November 28, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants