Merge pull request #120 from go-spectest/fix/response-body-close

Fix: image.EqualFromFile() close response body.
nao1215 · Oct 25, 2023 · c9171a8 · c9171a8
2 parents a0814e5 + e4ec0c0
commit c9171a8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # Changelog
 
-## [0.0.8, unreleased] - 2023-xx-xx
+## [0.0.9] - 2023-XX-XX
+### Fixed
+- image.EqualFromFile() close response body.
+
+## [0.0.8] - 2023-10-24
 ### Added
 - image package
   - Support image comparison; EqualFromFile()

diff --git a/image/image.go b/image/image.go
@@ -29,6 +29,8 @@ func EqualFromFile(expected string) func(*http.Response, *http.Request) error {
 		if err != nil {
 			return err
 		}
+		defer res.Body.Close() //nolint:errcheck
+
 		if _, err = tempFile.Write(body); err != nil {
 			return err
 		}