Fix issue148: Confirmation with [Y/n] should default to "yes" #147
Conversation
WalkthroughThe modification enhances the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
HOTTEST report
Reported by hottest |
Code Metrics Report
Details | | main (d398568) | #147 (7f385c7) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 77.7% | 77.7% | 0.0% |
| Files | 20 | 20 | 0 |
| Lines | 772 | 772 | 0 |
| Covered | 600 | 600 | 0 |
+ | Test Execution Time | 19s | 17s | -2s |Code coverage of files in pull request scope (100.0% → 100.0%)
Reported by octocov |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
internal/print/print.go (1)
Line range hint
78-78: Caution against potential infinite loops.The default case in the switch statement recursively calls
Questionif the user's input does not match 'y', 'yes', 'n', or 'no'. This could potentially lead to an infinite loop if the user continues to enter unrecognized inputs. Consider adding a maximum recursion depth or an alternative method to handle repeated invalid inputs.
| // If user input only enter, [Y/n] syntax is commonly used to denote that | ||
| // "yes" is the default. | ||
| // https://github.com/nao1215/gup/issues/146 | ||
| if strings.Contains(err.Error(), "expected newline") { | ||
| return Question(ask) | ||
| return true |
There was a problem hiding this comment.
Handle default response more robustly.
The current implementation relies on a specific error message to determine if the user has pressed enter without typing anything. This approach might not be robust as it depends on the error message string, which can change depending on the environment or updates to the Go language. Consider checking for an empty response string directly after trimming whitespace, which would be a more reliable method.
- if strings.Contains(err.Error(), "expected newline") {
+ if strings.TrimSpace(response) == "" {
+ return true
+ }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| // If user input only enter, [Y/n] syntax is commonly used to denote that | |
| // "yes" is the default. | |
| // https://github.com/nao1215/gup/issues/146 | |
| if strings.Contains(err.Error(), "expected newline") { | |
| return Question(ask) | |
| return true | |
| // If user input only enter, [Y/n] syntax is commonly used to denote that | |
| // "yes" is the default. | |
| // https://github.com/nao1215/gup/issues/146 | |
| if strings.TrimSpace(response) == "" { | |
| return true |
Summary by CodeRabbit