Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove SHA check before downloading mmd file #75

Merged
merged 2 commits into from
Dec 5, 2024
Merged

remove SHA check before downloading mmd file #75

merged 2 commits into from
Dec 5, 2024

Conversation

aperrin66
Copy link
Member

  • anonymous access to the github API is limited
  • we don't want to require authentication for pythesint
  • the file is small so the performance difference is negligible

@aperrin66
remove SHA check before downloading mmd file
5372647 
- anonymous access to the github API is limited
- we don't want to require authentication for pythesint
- the file is small so the performance difference is negligible
@aperrin66 aperrin66 self-assigned this Dec 5, 2024
@coveralls
Copy link

coveralls commented Dec 5, 2024 •
edited
Loading

Coverage Status

coverage: 95.455% (-0.1%) from 95.588%
when pulling 964ad26 on mmd_no_sha_check
into 0973793 on master.

@aperrin66 aperrin66 merged commit 1d37ba9 into master Dec 5, 2024
12 checks passed
@aperrin66 aperrin66 deleted the mmd_no_sha_check branch December 5, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aperrin66 aperrin66

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aperrin66 @coveralls