Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from EPTA version #232

Open
wants to merge 11 commits into
base: dcbusyweek
Choose a base branch
from
Open

Conversation

achalumeau
Copy link

This is an update from EPTA enterprise_extensions version. It is mostly to add new features and mainly compatible with previous version.

. blocks.py -> Change noise and common signal block to add new arguments, add features (e.g., fitting for Nbins) and re-order statements

. model_orfs.py -> Add diag argument to several orf functions, add new function

. model_utils.py -> Linting

. sampler.py -> Small change on 2 jump proposal functions

. chromatic/chromatic.py -> Allow a time window for the annual chromatic signal

. frequentist/optimal_statistic.py -> Simplify 2 if statements

@achalumeau
Copy link
Author

@vhaasteren , Just a ping to mention that I just solved a conflict and linted the code. It should be good to merge.

@vhaasteren
Copy link
Member

Sorry for being slow @achalumeau. In principle it's fine, except that the linting modified a lot of stuff that was already there. That means the code that was checked in was not properly linted before the github actions were this strict.

@AaronDJohnson, I think it's still fine to merge. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants