Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Focus to document before copying URL and title #62

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

nandenjin
Copy link
Owner

@nandenjin nandenjin commented Dec 12, 2024

Fixes #58


For more details, open the Copilot Workspace session.

@nandenjin nandenjin requested a review from Copilot December 12, 2024 04:38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

src/background/features/copyUrlAndTitle.ts:81

  • The new focus behavior should be covered by tests to ensure it works as intended across different scenarios.
if (!document.hasFocus()) {
@nandenjin nandenjin self-assigned this Dec 12, 2024
@nandenjin nandenjin added the bug Something isn't working label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotAllowedError: Failed to execute 'writeText' on 'Clipboard': Document is not focused.
1 participant