Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always check scripts with P2SH + Segwit #499

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Always check scripts with P2SH + Segwit #499

wants to merge 2 commits into from

Commits on Mar 28, 2022

  1. Always check scripts with P2SH + Segwit. 

    P2SH and Segwit have been activated on Namecoin for a long time now.
Upstream Bitcoin enforces those script flags (plus Taproot which is not
yet active on Namecoin) now unconditionally on the full block history,
except for certain specific blocks that would fail.

In Namecoin, actually all old blocks validate with P2SH and Segwit.  Thus
this changes GetBlockScriptFlags to always turn on P2SH and Segwit, which
tidies up / simplifies things and also brings the code more in line with
upstream.
    @domob1812
    domob1812 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    c8aeb92 View commit details
    Browse the repository at this point in the history

  2. Update name_segwit.py for always-on segwit. 

    Since script verification enforces segwit always now (without taking
activation into account), we can no longer check for cases where
transactions breaking segwit would be allowed pre-activation.

This simplifies name_segwit.py, and makes it now just double-check that
segwit is indeed enforced as it should be, as well as that generally
names on segwit addresses work.
    @domob1812
    domob1812 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    b0ded3d View commit details
    Browse the repository at this point in the history