Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some servers have spaces in empty lines, triggering an error parsing unl... #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lirm
Copy link

@lirm lirm commented Jan 28, 2014

...ess stripped

@buildhive
Copy link

Hiroshi Nakamura » httpclient #104 SUCCESS
This pull request looks good
(what's this?)

@nahi
Copy link
Owner

nahi commented May 21, 2014

Sorry for late response.

Interesting... Can I access the server, or can you provide captured response from the server?

@nahi nahi added the Feedback label Nov 3, 2014
@palkan
Copy link

palkan commented Feb 10, 2017

Hi, @nahi!

We're facing the the same error (using httpclient 2.8.x).

I've patched #parse_header method (https://github.com/palkan/httpclient/commit/cb2a3a91d834197d0aa9745cc8c1fe48b7e6d197) to raise a meaningful errors and it looks like it doesn't depend on the target server, more likely depends on network conditions.

Example errors:

Pusher::HTTPError: unexpected line: (size 2)

Faraday::ClientError: unexpected line: (size 2)

It looks like an empty line but has a size of 2. Do you have any idea?

UPD: maybe, the problem is somehow related to Sidekiq and it's multi-threading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants