Oracle databases do support prepared statement metadata retrieval apa…

…che#3515
nadment · Apr 7, 2024 · fc0e74d · fc0e74d
1 parent 1792d4b
commit fc0e74d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ns/databases/oracle/src/main/java/org/apache/hop/databases/oracle/OracleDatabaseMeta.java b/...ns/databases/oracle/src/main/java/org/apache/hop/databases/oracle/OracleDatabaseMeta.java
@@ -643,7 +643,7 @@ public boolean isRequiresCreateTablePrimaryKeyAppend() {
    */
   @Override
   public boolean isSupportsPreparedStatementMetadataRetrieval() {
-    return false;
+    return true;
   }
 
   /** @return The maximum number of columns in a database, <=0 means: no known limit */

diff --git a/...atabases/oracle/src/test/java/org/apache/hop/databases/oracle/OracleDatabaseMetaTest.java b/...atabases/oracle/src/test/java/org/apache/hop/databases/oracle/OracleDatabaseMetaTest.java
@@ -222,7 +222,7 @@ public void testOverriddenSettings() throws Exception {
         "http://download.oracle.com/docs/cd/B19306_01/java.102/b14355/urls.htm#i1006362",
         nativeMeta.getExtraOptionsHelpText());
     assertTrue(nativeMeta.isRequiresCreateTablePrimaryKeyAppend());
-    assertFalse(nativeMeta.isSupportsPreparedStatementMetadataRetrieval());
+    assertTrue(nativeMeta.isSupportsPreparedStatementMetadataRetrieval());
     String quoteTest1 = "FOO 'BAR' \r TEST \n";
     String quoteTest2 = "FOO 'BAR' \\r TEST \\n";
     assertEquals(