First lag on the way of eliminating os.system from dazel's code #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadirizr
reviewed
Oct 22, 2016
dazel.py
Outdated
| rc = 0 | ||
| if rc: | ||
| return rc | ||
| if not self._pull and not self._image_exists(): |
There was a problem hiding this comment.
I think you meant "self._pull()" right?
| decode=True): | ||
| if "error" in line: | ||
| print("ERROR:", line["error"]) | ||
| return False |
There was a problem hiding this comment.
There can only be one line of error?
There was a problem hiding this comment.
As far as I know, yes.
Docs are not clear about it though :(
|
|
||
| return rc | ||
| return 0 |
There was a problem hiding this comment.
Why not return True here to be consistent?
There was a problem hiding this comment.
Cause it's going to be returned from many other places, and I didn't want to refactor the whole code with that in mind. Its something we should do later on.
nadirizr
approved these changes
Oct 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've introduced docker-py into the code, and moved most of os.system(docker) calls to use that docker python api instead.
Next steps: Using docker-compose python api for the compose calls.