Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple selection via shift-click for controlled selection #219

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikhuang
Copy link

@mikhuang mikhuang commented Jun 2, 2020

Addresses https://github.com/nadbm/react-datasheet/pull/156/files#r307206217

Changes DataSheet onMouseDown while shift is held to account for when selection is controlled.

Add tests for shift-clicking for both controlled and uncontrolled selection.

mikhuang and others added 2 commits June 1, 2020 21:27
to account for when selection is controlled.

Add tests for shift-clicking for both controlled
and uncontrolled selection.
@lveillard
Copy link

Hello! I'm curious to know if this does fix both errors described on my issue?
#235
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants