Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUSE #319] Improve snakeyml compatibility for 2.2 #336

Merged

Conversation

pdkst
Copy link
Contributor

@pdkst pdkst commented Apr 2, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

improve snakeyml compatibility for 2.2

Brief changelog

修复snakeyml在2.2版本移除了默认构造器导致代码报错问题:

  • snakeyml2.0版本移除了默认的无参构造器,只有通过Options创建的构造器,这个修改会把1.29版本的snakeyml的构造器改成使用options构建的方式,兼容未来的版本;
  • nacos-config-spring-boot-starter:0.3.0-RC 已解决spring boot2.7版本后启动配置的问题,解决这个问题后,兼容spring boot 3.2没有其他兼容性错误

Verifying this change

ISSUSE 319

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024

CLA assistant check
All committers have signed the CLA.

@pdkst pdkst changed the title improve snakeyml compatibility for 2.2 [ISSUSE #319] Improve snakeyml compatibility for 2.2 Apr 2, 2024
@pdkst
Copy link
Contributor Author

pdkst commented Apr 2, 2024

@mercyblitz review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants