Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Made use of http loader optional via param #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nerdo
Copy link

@nerdo nerdo commented Jan 6, 2016

There're some cases where one doesn't want the http loader to run on a domain, e.g. for some background AJAX call. For those times, this update looks for the absence of (default behavior) or the presence of a falsy config.params.$useHttpLoader flag to bypass using it.

@chrisiconolly
Copy link
Contributor

Hi,

Question about your use case for this - is it requests to certain URLs that you don't want the loader to show for (ie: #28) OR are you after the ability to have the loader some times show, some times not, for the same urls?

For example:

WhitelistDomain('www.wonga.com')
BlacklistUrl('www.wonga.com', 'my-url')
means requests to www.wonga.com/my-url will never show the loader

@nerdo
Copy link
Author

nerdo commented Jan 7, 2016

It could be either. The latter use case covers the former.

By specifying the parameter as a default to the resource, you can blacklist
the url, but you always have the option to override it if necessary.
On Thu, Jan 7, 2016 at 3:52 AM Chris Conolly [email protected]
wrote:

Hi,

Question about your use case for this - is it requests to certain URLs
that you don't want the loader to show for (ie: #28
#28) OR are you
after the ability to have the loader some times show, some times not, for
the same urls?

For example:

WhitelistDomain('www.wonga.com')
BlacklistUrl('www.wonga.com', 'my-url')
means requests to www.wonga.com/my-url will never show the loader


Reply to this email directly or view it on GitHub
#29 (comment)
.

@tobiasc
Copy link

tobiasc commented Jan 14, 2016

I've updated the code running on our site (respondr.io) with the code from this PR (as we needed exactly this feature) and it works great. Thanks for the code :)

@zazoomauro
Copy link
Contributor

@nerdo can you please update the documentation with this? README and demo site as well!
Thanks

@nerdo
Copy link
Author

nerdo commented Jan 19, 2016

Hmm, not sure what I did wrong there, but I added the documentation, or at least I tried to.

@famagusta
Copy link

has this not been pulled into master yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants