Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Pipes #215

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Extra Pipes #215

merged 4 commits into from
Sep 26, 2023

Conversation

TMRh20
Copy link
Member

@TMRh20 TMRh20 commented Sep 26, 2023

Finally found some time to play around with this and it was pretty easy to implement. Just a few questions now like whether to try and support mixed networks (I don't really like that idea) but it seems to work fine.

  • Add support for any number of 'pipes' that are available for addressing.
  • Allows wider range of addressing on NRF52x devices

Instructions:

  • Edit RF24Network_config.h and set NUM_PIPES to 8
  • Edit RF24Mesh_config.h and set MESH_MAX_CHILDREN to 6
  • Recompile and upload...

#201

Add support for any number of 'pipes' that are available for addressing. Allows wider range of addressing on NRF52x devices
Copy link
Member

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so simple and clean! 😃

RF24Network_config.h Outdated Show resolved Hide resolved
RF24Network.cpp Outdated Show resolved Hide resolved
TMRh20 and others added 2 commits September 26, 2023 11:11
@2bndy5
Copy link
Member

2bndy5 commented Sep 26, 2023

Citing a concern from #201 OP

pipe/address validation will have to conditionally forego x <= 5 presumption about 6 pipes

I think is_valid_address() needs tweaking:

RF24Network/RF24Network.cpp

Lines 1134 to 1138 in a334fa6

if (digit < 1 || digit > 5) {
result = false;
IF_SERIAL_DEBUG_MINIMAL(printf_P(PSTR("*** WARNING *** Invalid address 0%o\n\r"), origNode););
break;
}

@TMRh20
Copy link
Member Author

TMRh20 commented Sep 26, 2023

I have it in the PR:
https://github.com/nRF24/RF24Network/pull/215/files#diff-8a8080552c7f675fa680e629d5c5baa2c875d8334cbd57d38b0e44bfc328b751R1134

Copy link
Member

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! I didn't see that change's context... LGTM

@TMRh20 TMRh20 merged commit 2b3b000 into master Sep 26, 2023
18 checks passed
@2bndy5 2bndy5 deleted the ExtraPipes branch February 17, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants