-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move allocation of addrList
into setNodeID()
#248
base: master
Are you sure you want to change the base?
Conversation
resolves #221 as proposed
The only problem this might cause is an invalid memory access when |
Memory usage change @ 04ca777
Click for full report table
Click for full report CSV
|
mesh.setNodeID(Serial.read()); | ||
mesh.setNodeID(Serial.parseInt() & 0xFF); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any noticeable increase in reported compile size comes from this change.
addrList
into setNodeID()
resolves #221 as proposed