Skip to content

Commit

Permalink
revert available() algorithm (#914)
Browse files Browse the repository at this point in the history
* fix #913

Essentially, this reverts the algorithm used to satisfy #650 as it has proved erroneous on fast MCUs.
  • Loading branch information
2bndy5 authored Aug 28, 2023
1 parent 890243c commit 01e6ccb
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
11 changes: 5 additions & 6 deletions RF24.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1521,22 +1521,21 @@ uint8_t RF24::getDynamicPayloadSize(void)

bool RF24::available(void)
{
uint8_t pipe = 0;
uint8_t pipe = RF24_NO_FETCH_PIPE;
return available(&pipe);
}

/****************************************************************************/

bool RF24::available(uint8_t* pipe_num)
{
// get implied RX FIFO empty flag from status byte
uint8_t pipe = (get_status() >> RX_P_NO) & 0x07;
if (pipe > 5)
if (read_register(FIFO_STATUS) & 1) { // if RX FIFO is empty
return 0;
}

// If the caller wants the pipe number, include that
if (pipe_num)
*pipe_num = pipe;
if (*pipe_num != RF24_NO_FETCH_PIPE)
*pipe_num = (get_status() >> RX_P_NO) & 0x07;

return 1;
}
Expand Down
3 changes: 3 additions & 0 deletions RF24_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@
#define RF24_SPI_SPEED 10000000
#endif

/// A sentinel used to control fetching the pipe info in `RF24::available()`.
#define RF24_NO_FETCH_PIPE 0XFF

//ATXMega
#if defined(__AVR_ATxmega64D3__) || defined(__AVR_ATxmega128D3__) || defined(__AVR_ATxmega192D3__) || defined(__AVR_ATxmega256D3__) || defined(__AVR_ATxmega384D3__)
// In order to be available both in Windows and Linux this should take presence here.
Expand Down

0 comments on commit 01e6ccb

Please sign in to comment.