Fix: no longer using a pointer to a movable stack item #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're feeding OpenTraceA with an EVENT_TRACE_LOGFILE, which contains (at least) two pointers: * one to the callback, run on every ETW event This one points to a static location in code * one to a `PVOID Context` that Windows will give back as argument of the callback This points at `UserTrace.data`, which previously lived on the stack. This means that moving the UserTrace (e.g. by returning it in a function result) would break the pointer. This is fixed by putting UserTrace.data on the heap. It is now the responsability of the ferrisetw developer (and not its user, who was unaware of it) to *not* move it. This changes the public API, so this means this should be released as a new major number of this crate
n4r1b
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're feeding OpenTraceA with an EVENT_TRACE_LOGFILE, which contains (at least) two pointers:
PVOID Contextthat Windows will give back as argument of the callback This points atUserTrace.data, which previously lived on the stack. This means that moving the UserTrace (e.g. by returning it in a function result) would break the pointer. This is fixed by putting UserTrace.data on the heap. It is now the responsability of the ferrisetw developer (and not its user, who was unaware of it) to not move it.This changes the public API, so this means this should be released as a new major number of this crate
Refs #18