Using a bitfield for TraceFlags #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daladim
force-pushed
the
traceflags_bitmask
branch
from
ead8d59 to
a78e217
Compare
daladim
force-pushed
the
traceflags_bitmask
branch
from
a78e217 to
9776114
Compare
n4r1b
approved these changes
Sep 14, 2022
|
That's what I've actually done in a former commit, when I created the |
|
Thanks for rhe review. I'm merging into this "staging" branch, that we'll merge into develop whenever you're ready to release a new major version (but I still have a bunch of proposals before it makes sense to 😄 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's the first change I'd like to integrate into the next major version
Refs #18