Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Github Actions #20

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Added Github Actions #20

merged 3 commits into from
Aug 11, 2022

Conversation

daladim
Copy link
Collaborator

@daladim daladim commented Aug 9, 2022

Closes #16

This is using the basic Rust action automatically suggested by GitHub.
The stock https://github.com/BamPeers/rust-ci-github-actions-workflow you suggested seems to run on Ubuntu. I'm not sure forking and customizing it is worth it.

I think we'll always be able to add clippy, rustfmt, etc. later from this first step

@daladim
Copy link
Collaborator Author

daladim commented Aug 9, 2022

Hmm, I did not read https://github.com/BamPeers/rust-ci-github-actions-workflow thoroughly, there are many good ideas there that are easy to use after all.

I'll push new commits

@daladim
Copy link
Collaborator Author

daladim commented Aug 9, 2022

Well, I cannot fix all Clippy errors without bumping to a new major version.

Thus, I am not (yet) adding a Clippy job in this MR.
I think using advanced test with code coverage is out of my reach for this MR.

So, I'm not sure how completely this MR closes #18 , I'll let you decide whether you'll want to keep this issue open after this MR

@roblabla
Copy link
Contributor

roblabla commented Aug 9, 2022

I hightly suggest using the actions from https://github.com/actions-rs. They run on all runners (including windows), are well maintained, and provide a lot of niceties, such as proper parsing of rust's output to annotate the diff views with warning/errors, or downloading a known version of the rust compiler.

A minimal version of this would be replacing the cargo build and cargo test jobs with

      - uses: actions-rs/toolchain@v1
        with:
          profile: minimal
          toolchain: stable
          override: true
      - uses: actions-rs/cargo@v1
        with:
          command: test

@daladim
Copy link
Collaborator Author

daladim commented Aug 9, 2022

Thanks for the suggestion @roblabla , I've added jobs from actions-rs

Copy link
Owner

@n4r1b n4r1b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks @daladim

@n4r1b n4r1b merged commit da304e9 into n4r1b:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Github Actions
3 participants