-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [plugins/prometheus] fixes for phases/shouldObserve for Yoga #2326
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: adade56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Benchmark Results
|
💻 Website PreviewThe latest changes are available as preview in: https://11e6a059.envelop.pages.dev |
4545487
to
2ef6adc
Compare
phases?: AtLeastOne<Phases>; | ||
shouldObserve?: ShouldObservePredicate<Params>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it's a new thing from the previous PR.
Perhaps it would be clearer to review if I revert the merge commit from previous PR and cherry-pick it in this one ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, was just wondering.
Minor fixes required to propagate phases/shouldObserve new config to Yoga plugin.