Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [plugins/prometheus] fixes for phases/shouldObserve for Yoga #2326

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

EmrysMyrddin
Copy link
Collaborator

Minor fixes required to propagate phases/shouldObserve new config to Yoga plugin.

Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: adade56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/prometheus Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 12, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/prometheus 11.1.0-alpha-20241122091727-adade563355e3d213f27427a9a1d86adf9431d41 npm ↗︎ unpkg ↗︎

@theguild-bot
Copy link
Collaborator

theguild-bot commented Nov 12, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 666596      ✗ 0     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: 100.00% ✓ 145698      ✗ 0     
     ✓ { mode:envelop-cache-jit }.......................: 100.00% ✓ 281882      ✗ 0     
     ✓ { mode:envelop-just-cache }......................: 100.00% ✓ 148848      ✗ 0     
     ✓ { mode:graphql-js }..............................: 100.00% ✓ 90168       ✗ 0     
     data_received......................................: 2.5 GB  21 MB/s
     data_sent..........................................: 145 MB  1.2 MB/s
     envelop_init.......................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     graphql_context....................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     graphql_execute....................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     graphql_parse......................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     graphql_validate...................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=3.57µs  min=1.08µs   med=2.65µs  max=17.1ms  p(90)=3.67µs  p(95)=4.22µs 
     http_req_connecting................................: avg=16ns    min=0s       med=0s      max=1.02ms  p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=3.23ms  min=158.83µs med=2.92ms  max=48.14ms p(90)=6.02ms  p(95)=7.11ms 
       { expected_response:true }.......................: avg=3.23ms  min=158.83µs med=2.92ms  max=48.14ms p(90)=6.02ms  p(95)=7.11ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=3.79ms  min=386.59µs med=3.22ms  max=23.54ms p(90)=6.25ms  p(95)=7.01ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=1.71ms  min=158.83µs med=1.34ms  max=22.97ms p(90)=2.89ms  p(95)=3.67ms 
     ✓ { mode:envelop-just-cache }......................: avg=3.7ms   min=383.6µs  med=3.19ms  max=23.67ms p(90)=6.11ms  p(95)=6.85ms 
     ✓ { mode:graphql-js }..............................: avg=6.33ms  min=745.67µs med=5.43ms  max=48.14ms p(90)=10.24ms p(95)=11.54ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 333298
     http_req_receiving.................................: avg=43.87µs min=12.09µs  med=31.8µs  max=19.88ms p(90)=50.41µs p(95)=58.88µs
     http_req_sending...................................: avg=16.81µs min=3.57µs   med=10.47µs max=16.54ms p(90)=20.21µs p(95)=21.94µs
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=3.17ms  min=131.93µs med=2.87ms  max=48.03ms p(90)=5.95ms  p(95)=7.03ms 
     http_reqs..........................................: 333298  2777.238844/s
     iteration_duration.................................: avg=3.59ms  min=383.29µs med=3.21ms  max=48.57ms p(90)=6.39ms  p(95)=7.58ms 
     iterations.........................................: 333298  2777.238844/s
     vus................................................: 10      min=10        max=10  
     vus_max............................................: 20      min=20        max=20  

Copy link
Contributor

github-actions bot commented Nov 12, 2024

💻 Website Preview

The latest changes are available as preview in: https://11e6a059.envelop.pages.dev

@EmrysMyrddin EmrysMyrddin marked this pull request as ready for review November 22, 2024 08:20
@EmrysMyrddin EmrysMyrddin force-pushed the feat/prometheus/yoga-skip-request branch from 4545487 to 2ef6adc Compare November 22, 2024 09:15
Comment on lines +98 to +99
phases?: AtLeastOne<Phases>;
shouldObserve?: ShouldObservePredicate<Params>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's a new thing from the previous PR.
Perhaps it would be clearer to review if I revert the merge commit from previous PR and cherry-pick it in this one ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, was just wondering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants