Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle to 7.5 #211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade Gradle to 7.5 #211

wants to merge 2 commits into from

Conversation

Fiouz
Copy link

@Fiouz Fiouz commented Aug 2, 2022

  • Upgrade Gradle from 7.0 to 7.5
  • Update the existing unit test to test Gradle 7.5
  • Also add GitHub Gradle Wrapper binary checking to avoid tampering

@VitaliyKulikov
Copy link

VitaliyKulikov commented Aug 2, 2022

also, you can use in your readme file the way how to use git properties in a modern way)

version = project.provider{project.ext.gitProps['git.commit.id.abbrev']}

https://docs.gradle.org/current/javadoc/org/gradle/api/provider/Provider.html

@Fiouz
Copy link
Author

Fiouz commented Aug 4, 2022

also, you can use in your readme file the way how to use git properties in a modern way)

version = project.provider{project.ext.gitProps['git.commit.id.abbrev']}

https://docs.gradle.org/current/javadoc/org/gradle/api/provider/Provider.html

The scope of this PR is purposely limited to changing the version of the build tool, in order to facilitate code review.
As such, upgrading the project to modern Gradle idioms that were already missing before this PR (the Provider API has been around since Gradle 4) will not be done here (this can be done in a separate PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants