+ IQueryable<>.FilterByItems() from https://stackoverflow.com/quest…

…ions/67666649/lambda-linq-with-contains-criteria-for-multiple-keywords/67666993#67666993 to replace `IQueryable<>.WhereOrContainsValues()` except its last usage in `SaverWithRevision.AddRevisionsWithDuplicateIndex()` since it's passing a visited non-generic expression @ ExtensionMethods.cs

@ c#/crawler

c#/crawler/src/ExtensionMethods.cs

@@ -73,4 +73,44 @@ public static IQueryable<TEntity> WhereOrContainsValues<TEntity, TToCompare>(
                     LinqKit.PredicateBuilder.New<TEntity>(),
                     (innerPredicate, expressionFactory) =>
                         innerPredicate.And(expressionFactory(valueToCompare))))));
+
+    /// <see>https://stackoverflow.com/questions/67666649/lambda-linq-with-contains-criteria-for-multiple-keywords/67666993#67666993</see>
+    public static IQueryable<T> FilterByItems<T, TItem>(
+        this IQueryable<T> query,
+        IEnumerable<TItem> items,
+        Expression<Func<T, TItem, bool>> filterPattern,
+        bool isOr = true)
+    {
+        var predicate = items.Aggregate<TItem, Expression?>(null, (current, item) =>
+        {
+            var itemExpr = Expression.Constant(item);
+            var itemCondition = FilterByItemsExpressionReplacer
+                .Replace(filterPattern.Body, filterPattern.Parameters[1], itemExpr);
+
+            return current == null
+                ? itemCondition
+                : Expression.MakeBinary(isOr ? ExpressionType.OrElse : ExpressionType.AndAlso,
+                    current,
+                    itemCondition);
+        }) ?? Expression.Constant(false);
+        var filterLambda = Expression.Lambda<Func<T, bool>>(predicate, filterPattern.Parameters[0]);
+
+        return query.Where(filterLambda);
+    }
+
+    private class FilterByItemsExpressionReplacer(IDictionary<Expression, Expression> replaceMap) : ExpressionVisitor
+    {
+        private readonly IDictionary<Expression, Expression> _replaceMap
+            = replaceMap ?? throw new ArgumentNullException(nameof(replaceMap));
+
+        [return: NotNullIfNotNull(nameof(exp))]
+        public override Expression? Visit(Expression? exp) =>
+            exp != null && _replaceMap.TryGetValue(exp, out var replacement)
+                ? replacement
+                : base.Visit(exp);
+
+        public static Expression Replace(Expression expr, Expression toReplace, Expression toExpr) =>
+            new FilterByItemsExpressionReplacer(new Dictionary<Expression, Expression> {{toReplace, toExpr}})
+                .Visit(expr);
+    }
 }

c#/crawler/src/Tieba/Crawl/Saver/ReplyContentImageSaver.cs

@@ -104,11 +104,9 @@ on existingOrNew.UrlFilename equals replyContentImage.ImageInReply.UrlFilename
                 select (existingOrNew, replyContentImage))
             .ForEach(t => t.replyContentImage.ImageInReply = t.existingOrNew);
         var existingReplyContentImages = db.ReplyContentImages.AsNoTracking()
-            .WhereOrContainsValues(replyContentImages, [
-                newOrExisting => existing => existing.Pid == newOrExisting.Pid,
-                newOrExisting => existing =>
-                    existing.ImageInReply.UrlFilename == newOrExisting.ImageInReply.UrlFilename
-            ])
+            .FilterByItems(replyContentImages, (existing, newOrExisting) =>
+                existing.Pid == newOrExisting.Pid
+                && existing.ImageInReply.UrlFilename == newOrExisting.ImageInReply.UrlFilename)
             .Include(e => e.ImageInReply)
             .Select(e => new {e.Pid, e.ImageInReply.UrlFilename})
             .ToList();

c#/crawler/src/Tieba/Crawl/Saver/ReplySignatureSaver.cs

@@ -40,10 +40,11 @@ public Action Save(CrawlerDbContext db, IEnumerable<ReplyPost> replies)
                 r => r.Signature,
                 SignatureIdAndValueEqualityComparer.Instance);
 
-        var existingSignatures = db.ReplySignatures.AsTracking().WhereOrContainsValues(signatures, [
-            newOrExisting => existing => existing.SignatureId == newOrExisting.SignatureId,
-            newOrExisting => existing => existing.XxHash3 == newOrExisting.XxHash3
-        ]).ToList();
+        var existingSignatures = db.ReplySignatures.AsTracking().FilterByItems(
+                signatures, (existing, newOrExisting) =>
+                    existing.SignatureId == newOrExisting.SignatureId
+                    && existing.XxHash3 == newOrExisting.XxHash3)
+            .ToList();
         (from existing in existingSignatures
                 join newInReply in signatures on existing.SignatureId equals newInReply.SignatureId
                 select (existing, newInReply))

c#/crawler/src/Tieba/Crawl/Saver/ThreadLatestReplierSaver.cs

@@ -11,11 +11,11 @@ public Action Save(CrawlerDbContext db, IReadOnlyCollection<ThreadPost> threads)
         var uniqueLatestRepliers = threads
             .Where(th => th.LatestReplier != null)
             .Select(UniqueLatestReplier.FromThread).ToList();
-        var existingLatestRepliers = db.LatestRepliers.AsNoTracking().WhereOrContainsValues(uniqueLatestRepliers,
-        [
-            newOrExisting => existing => existing.Name == newOrExisting.Name,
-            newOrExisting => existing => existing.DisplayName == newOrExisting.DisplayName
-        ]).ToList();
+        var existingLatestRepliers = db.LatestRepliers.AsNoTracking().FilterByItems(
+            uniqueLatestRepliers, (latestReplier, uniqueLatestReplier) =>
+                latestReplier.Name == uniqueLatestReplier.Name
+                && latestReplier.DisplayName == uniqueLatestReplier.DisplayName)
+            .ToList();
         (from existing in existingLatestRepliers
                 join thread in threads
                     on UniqueLatestReplier.FromLatestReplier(existing) equals UniqueLatestReplier.FromThread(thread)