* fix not invoking the action returned by `ReplyContentImageSaver.Sav…

…e()` to release its locked images, by manually dispose it and recreate another instance of saver after `DbContext.SaveChanges()` @ `DoWork()`

* rename primary ctor param `replyContentImageSaver` to `replyContentImageSaverFactory as its original type now being wrapped in `Func<Owned<>>`
@ ProcessImagesInAllReplyContentsWorker.cs

* instead of throwing `InvalidOperationException, logging about the failure when removing global locked image
@ `ReplyContentImageSaver.Dispose()`
@ crawler

+ param `afterSaveChangesAction` @ `TransformEntityWorker.Transform()`
@ shared
@ c#

c#/crawler/src/Tieba/Crawl/Saver/ReplyContentImageSaver.cs

@@ -11,9 +11,12 @@ public void Dispose()
     {
         try
         {
-            if (_newlyLockedImages != null && _newlyLockedImages.Any(pair =>
-                    !GlobalLockedImagesInReplyKeyByUrlFilename.TryRemove(pair)))
-                throw new InvalidOperationException();
+            _newlyLockedImages?.ForEach(pair =>
+            {
+                if (!GlobalLockedImagesInReplyKeyByUrlFilename.TryRemove(pair))
+                    logger.LogError("Previously locked image {} already removed from the global locks",
+                        SharedHelper.UnescapedJsonSerialize(pair));
+            });
         }
         finally
         {

c#/crawler/src/Worker/ProcessImagesInAllReplyContentsWorker.cs

@@ -5,7 +5,7 @@ public class ProcessImagesInAllReplyContentsWorker(
     IConfiguration config,
     Func<Owned<CrawlerDbContext.NewDefault>> dbContextDefaultFactory,
     Func<Owned<CrawlerDbContext.New>> dbContextFactory,
-    ReplyContentImageSaver replyContentImageSaver)
+    Func<Owned<ReplyContentImageSaver>> replyContentImageSaverFactory)
     : TransformEntityWorker<CrawlerDbContext, ReplyContent, ReplyContent, Pid>(logger)
 {
     protected override async Task DoWork(CancellationToken stoppingToken)
@@ -21,6 +21,7 @@ protected override async Task DoWork(CancellationToken stoppingToken)
         {
             logger.LogInformation("Simplify images in reply contents of fid {} started", fid);
             var replyContentsKeyByPid = new Dictionary<Pid, RepeatedField<Content>>(saveWritingEntitiesBatchSize);
+            var replyContentImageSaver = replyContentImageSaverFactory();
             await using var dbFactory = dbContextFactory();
             await Transform(
                 () => dbFactory.Value(fid),
@@ -53,13 +54,19 @@ await Transform(
                         var p = ee.Property(e => e.ProtoBufBytes);
                         p.IsModified = !ByteArrayEqualityComparer.Instance.Equals(p.OriginalValue, p.CurrentValue);
                     });
-                    replyContentImageSaver.Save(writingDb, replyContentsKeyByPid.Select(pair => new ReplyPost
-                    {
-                        Pid = pair.Key,
-                        Content = null!,
-                        ContentsProtoBuf = pair.Value
-                    }));
+                    _ = replyContentImageSaver.Value.Save(writingDb,
+                        replyContentsKeyByPid.Select(pair => new ReplyPost
+                        {
+                            Pid = pair.Key,
+                            Content = null!,
+                            ContentsProtoBuf = pair.Value
+                        }));
+                },
+                () =>
+                {
                     replyContentsKeyByPid.Clear();
+                    replyContentImageSaver.Dispose();
+                    replyContentImageSaver = replyContentImageSaverFactory();
                 },
                 stoppingToken);
             logger.LogInformation("Simplify images in reply contents of fid {} finished after {:F2}s",

c#/shared/src/TransformEntityWorker.cs

@@ -32,6 +32,7 @@ protected async Task Transform(
         Func<TReadingEntity, TWritingEntity> writingEntityFactory,
         Action<TReadingEntity, TWritingEntity> writingEntityMutator,
         Action<TDbContext, IReadOnlyCollection<EntityEntry<TWritingEntity>>> writingEntityEntriesAction,
+        Action afterSaveChangesAction,
         CancellationToken stoppingToken = default)
     {
         var processedEntityCount = 0;
@@ -52,6 +53,7 @@ async Task SaveThenLog(int processedCount, Process currentProcess)
             var updatedEntityCount = await writingDb.SaveChangesAsync(stoppingToken);
             writingDb.ChangeTracker.Clear();
             writingEntityEntries.Clear();
+            afterSaveChangesAction();
 
             logger.LogTrace("processedEntityCount:{} updatedEntityCount:{} elapsed:{}ms processMemory:{:F2}MiB exceptions:{}",
                 processedCount, updatedEntityCount,