* ignore _ide_helper*.php and disable some rules @ phpmd.xml

* fix returning `HasOne` instead of `Builder` in runtine since 37dbe24 @ `App\Http\Controllers\PostQuery->query()` @ be $ git ls-files -z | xargs -0 dos2unix
n0099 · Sep 15, 2024 · 2766c30 · 2766c30
1 parent efe7d9a
commit 2766c30
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 10 deletions.
diff --git a/be/app/Http/Controllers/PostsQuery.php b/be/app/Http/Controllers/PostsQuery.php
@@ -61,10 +61,7 @@ public function query(\Illuminate\Http\Request $request): array
             ->concat(LatestReplier::query()->whereIn('id', $latestRepliersId)
                 ->whereNull('uid')->selectPublicFields()
                 ->addSelect(['name', 'displayName'])->get());
-        $whereCurrentFid = /**
-         * @psalm-return \Illuminate\Database\Eloquent\Builder<TRelatedModel>
-         */
-        static fn(HasOne $q): \Illuminate\Database\Eloquent\Builder => $q->where('fid', $result['fid']);
+        $whereCurrentFid = static fn(HasOne $q): HasOne => $q->where('fid', $result['fid']);
         $users = User::query()->whereIn(
             'uid',
             collect($result)

diff --git a/be/phpmd.xml b/be/phpmd.xml
@@ -6,11 +6,27 @@
     xsi:noNamespaceSchemaLocation="http://phpmd.org/xml/ruleset_xml_schema_1.0.0.xsd">
     <!-- https://github.com/phpmd/phpmd/issues/506 -->
     <exclude-pattern>vendor</exclude-pattern>
+    <exclude-pattern>_ide_helper*.php</exclude-pattern>
     <!-- https://github.com/phpmd/phpmd/tree/2.15.0/src/main/resources/rulesets -->
-    <rule ref="rulesets/cleancode.xml" />
+    <!-- https://gist.github.com/slayerfat/2b3cc4faf94d2863b505 -->
+    <rule ref="rulesets/cleancode.xml">
+        <exclude name="StaticAccess" />
+        <exclude name="BooleanArgumentFlag" />
+        <exclude name="MissingImport" />
+    </rule>
+    <rule ref="rulesets/cleancode.xml/MissingImport">
+        <properties>
+            <property name="ignore-global" value="true" />
+        </properties>
+    </rule>
     <rule ref="rulesets/codesize.xml" />
     <rule ref="rulesets/controversial.xml" />
     <rule ref="rulesets/design.xml" />
-    <rule ref="rulesets/naming.xml" />
-    <rule ref="rulesets/unusedcode.xml" />
+    <rule ref="rulesets/naming.xml">
+        <exclude name="LongVariable" />
+        <exclude name="ShortVariable" />
+    </rule>
+    <rule ref="rulesets/unusedcode.xml">
+        <exclude name="UnusedFormalParameter" />
+    </rule>
 </ruleset>
diff --git a/c#/crawler/src/Db/BaseUser.cs b/c#/crawler/src/Db/BaseUser.cs
@@ -1,4 +1,4 @@
-namespace tbm.Crawler.Db;
+namespace tbm.Crawler.Db;
 
 public abstract class BaseUser : TimestampedEntity
 {

diff --git a/c#/crawler/src/Db/LatestReplier.cs b/c#/crawler/src/Db/LatestReplier.cs
@@ -1,4 +1,4 @@
-// ReSharper disable PropertyCanBeMadeInitOnly.Global
+// ReSharper disable PropertyCanBeMadeInitOnly.Global
 namespace tbm.Crawler.Db;
 
 public class LatestReplier : BaseUser

diff --git a/c#/crawler/src/Db/Revision/LatestReplierRevision.cs b/c#/crawler/src/Db/Revision/LatestReplierRevision.cs
@@ -1,4 +1,4 @@
-// ReSharper disable PropertyCanBeMadeInitOnly.Global
+// ReSharper disable PropertyCanBeMadeInitOnly.Global
 namespace tbm.Crawler.Db.Revision;
 
 public class LatestReplierRevision