introduce typescript #447
Open
introduce typescript #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-rook
requested changes
Aug 20, 2023
| @@ -42,6 +42,7 @@ | |||
| <script> | |||
| const showGameColumn = "{{show_game}}"; | |||
| const showRouteColumn = "{{show_route}}"; | |||
| const aaaa = "aaaaa"; | |||
| @@ -1,205 +1,200 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
Sorry to be annoying by saying this, but: We really shouldn't check in generated code. Rather, we should recreate it whenever we deploy.
If you really need to, it might be okay to check it in as an intermediate step while you're trying to get the ts deploy working, but if so, please put a giant comment at the top warning that this is generated code. But it'd be way better to do it in one go.
| } | ||
|
|
||
| function ensureTickboxSync(): void { | ||
| activeFilters = initializeFilters(); |
There was a problem hiding this comment.
Er--- why are we calling initializeFilters() three times in this module?
| @@ -23,38 +23,38 @@ def convert_replay_to_dict(self, replay: models.Replay) -> dict: | |||
| score_prefix = _get_medal_emoji(replay.rank) if hasattr(replay, "rank") else "" | |||
|
|
|||
| json_dict = {} | |||
| json_dict["Id"] = replay.id | |||
| json_dict["id"] = replay.id | |||
There was a problem hiding this comment.
IMO you should really make these changes in a separate PR; they make this one look much bigger than it needs to be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding types here to make the logic easier to follow