Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cmd.go should use no_udp flag from saved config #50

Merged
merged 3 commits into from
Jul 6, 2023
Merged

fix: cmd.go should use no_udp flag from saved config #50

merged 3 commits into from
Jul 6, 2023

Conversation

buptsb
Copy link
Contributor

@buptsb buptsb commented Jul 6, 2023

No description provided.

mzz2017
mzz2017 reviewed Jul 6, 2023
View reviewed changes
Copy link
Owner

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check the argument? If it exists, prefer to use it, or use config setting.

@buptsb
Copy link
Contributor Author

buptsb commented Jul 6, 2023

Updated.

@mzz2017
Copy link
Owner

mzz2017 commented Jul 6, 2023

LGTM. Thanks for your contribution!

@mzz2017 mzz2017 merged commit 0f784b9 into mzz2017:main Jul 6, 2023
5 checks passed
@buptsb buptsb deleted the zckevin-patch-1 branch July 6, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzz2017 mzz2017 mzz2017 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buptsb @mzz2017