Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix require paths for config-yargs, convert-argv, SearchSource and createContext #45

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jonesnc
Copy link

@jonesnc jonesnc commented Dec 19, 2019

Also fixes tests for common-flags.test.js

@jonesnc jonesnc mentioned this pull request Dec 19, 2019
@jonesnc
Copy link
Author

jonesnc commented Dec 19, 2019

The TravisCI build isn't passing with this error:

$ npm test
> [email protected] test /home/travis/build/mzgoddard/jest-webpack
> node ./jest-webpack.js --maxWorkers 1
internal/modules/cjs/loader.js:969
    throw err;
    ^

Error: Cannot find module 'find-up'
Require stack:
- /home/travis/build/mzgoddard/jest-webpack/src/jest-webpack.js
- /home/travis/build/mzgoddard/jest-webpack/jest-webpack.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:966:17)
    at Function.Module._load (internal/modules/cjs/loader.js:859:27)
    at Module.require (internal/modules/cjs/loader.js:1028:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/home/travis/build/mzgoddard/jest-webpack/src/jest-webpack.js:4:16)
    at Module._compile (internal/modules/cjs/loader.js:1139:30)
    at loader (/home/travis/build/mzgoddard/jest-webpack/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.<computed> [as .js] (/home/travis/build/mzgoddard/jest-webpack/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (internal/modules/cjs/loader.js:988:32)
    at Function.Module._load (internal/modules/cjs/loader.js:896:14) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/travis/build/mzgoddard/jest-webpack/src/jest-webpack.js',
    '/home/travis/build/mzgoddard/jest-webpack/jest-webpack.js'
  ]
}

npm ERR! Test failed.  See above for more details.

The command "npm test" exited with 1.

I think this stems from npm install ... removing some of the packages that yarn installs, including find-up.

@jonesnc
Copy link
Author

jonesnc commented Dec 19, 2019

Replacing npm install ... with yarn add .. in the Travis CI build script will probably fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant