Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more timeouts to endless contexts #6029

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

soffokl
Copy link
Member

@soffokl soffokl commented Apr 4, 2024

This pull request adds timeouts to the endless contexts in the alignWithHermes and recoverGrandTotalPromised functions to prevent potential resource leaks.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.93%. Comparing base (4a517cd) to head (1882dab).
Report is 42 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6029      +/-   ##
==========================================
+ Coverage   37.90%   37.93%   +0.02%     
==========================================
  Files         371      371              
  Lines       20665    20699      +34     
==========================================
+ Hits         7833     7852      +19     
- Misses      12054    12063       +9     
- Partials      778      784       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soffokl soffokl merged commit 41bffb1 into master Apr 4, 2024
20 checks passed
@soffokl soffokl deleted the add-more-context-timeouts branch April 4, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants