Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Surrey] Don’t fetch & upload photos from media_url #361

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

davea
Copy link
Member

@davea davea commented Sep 17, 2024

Photos should only be uploaded if the photo content was POSTed from FMS.

@davea davea requested a review from dracos September 17, 2024 15:13
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional line to remove - do they handle fetching it at their end in this case, then?

@@ -311,16 +311,10 @@ sub _add_attachments {
my $ua = LWP::UserAgent->new(agent => "FixMyStreet/open311-adapter");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed now.

@davea
Copy link
Member Author

davea commented Sep 17, 2024

Yes, we can either provide the base64 or url (and they fetch it if base64 isn't there).

@davea davea requested a review from dracos September 17, 2024 15:18
Photos should only be uploaded if the photo content was
POSTed from FMS.
@davea davea force-pushed the surrey-only-send-private-photos branch from 5db838a to d8cfef2 Compare September 17, 2024 17:50
@davea davea merged commit d8cfef2 into master Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants