Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Surrey] Adds externalId for jobs and reports #354

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[Surrey] Adds externalId for jobs and reports #354

merged 1 commit into from
Aug 7, 2024

Conversation

MorayMySoc
Copy link
Contributor

@MorayMySoc MorayMySoc requested a review from dracos August 6, 2024 15:48
dracos
dracos requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the spec doc you link to here, externalId would be on fmsReport, not inside confirmEnquiry or confirmJob.

@MorayMySoc MorayMySoc requested a review from dracos August 7, 2024 10:16
@mysociety-pusher mysociety-pusher force-pushed the surrey-boomi-external-id branch from d139b30 to a19ad6e Compare August 7, 2024 11:15
@mysociety-pusher mysociety-pusher merged commit a19ad6e into surrey-boomi Aug 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dracos dracos dracos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MorayMySoc @dracos @mysociety-pusher