Glos confirm integration post testing fixes #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nephila-nacrea
force-pushed
the
glos-confirm-integration-post-testing-fixes
branch
2 times, most recently
from
0f60223
to
eb36f90
Compare
Codecov Report
@@ Coverage Diff @@
## glos-confirm-integration #293 +/- ##
============================================================
+ Coverage 82.67% 82.71% +0.03%
============================================================
Files 113 113
Lines 3839 3841 +2
Branches 578 579 +1
============================================================
+ Hits 3174 3177 +3
Misses 413 413
+ Partials 252 251 -1
|
nephila-nacrea
force-pushed
the
glos-confirm-integration-post-testing-fixes
branch
from
1a12242
to
52dbea4
Compare
davea
reviewed
Aug 16, 2023
There was a problem hiding this comment.
This looks fine, but I wonder if it would be better to do the string manipulation in Gloucestershire::open311_extra_data_include in FMS, given that already exists? Doing it here in open311-adapter means that there's Gloucestershire-specific functionality in two places rather than one.
davea
approved these changes
Aug 18, 2023
Gloucestershire cobrand in fms repo sets a special location attribute; we need to make sure it is handled in perllib/Open311/Endpoint/Integration/Confirm.pm here.
nephila-nacrea
force-pushed
the
glos-confirm-integration-post-testing-fixes
branch
from
2bcba61
to
1f07fd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the to-dos in https://3.basecamp.com/4020879/buckets/32187059/todolists/5997794619.