[Surrey][Boomi] Change source of external reference

Use the externalId of the FMS report object instead of the the 'externalSystemReference' or 'jobNumber' from the log of enquiries or jobs. mysociety/societyworks#4535
mysociety · Oct 4, 2024 · f275f92 · f275f92
1 parent 50ecad7
commit f275f92
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/perllib/Open311/Endpoint/Integration/Boomi.pm b/perllib/Open311/Endpoint/Integration/Boomi.pm
@@ -251,12 +251,10 @@ sub _get_service_request_updates_for_integration_id {
         my $log = $enquiry_update ? $update->{confirmEnquiryStatusLog} : $update->{confirmJobStatusLog};
         my $fms = $update->{fmsReport};
 
-        my $id = $enquiry_update
-            ? $log->{enquiry}->{externalSystemReference} . "_" . $log->{logNumber}
-            : $log->{job}->{jobNumber} . "_" . $log->{logNumber};
+        my $id = $fms->{externalId} . "_" . $log->{logNumber};
         my $service_request_id = $enquiry_update
-            ? "Zendesk_" . $log->{enquiry}->{externalSystemReference}
-            : "Zendesk_JOB_" . $log->{job}->{jobNumber};
+            ? "Zendesk_" . $fms->{externalId}
+            : "Zendesk_JOB_" . $fms->{externalId};
         my $status = lc $fms->{status}->{state};
         $status =~ s/ /_/g;
         # fixup invalid status from Boomi

diff --git a/t/open311/endpoint/surrey_boomi.t b/t/open311/endpoint/surrey_boomi.t
@@ -155,10 +155,10 @@ $lwp->mock(request => sub {
                             "statusCode" => "5800",
                             "enquiry" => {
                                 "enquiryNumber" => 129293,
-                                "externalSystemReference" => "2929177"
                             }
                         },
                         "fmsReport" => {
+                            "externalId" => 2929177,
                             "status" => {
                                 "state" => "Closed",
                                 "label" => "Enquiry closed"
@@ -172,10 +172,10 @@ $lwp->mock(request => sub {
                             "statusCode" => "3200",
                             "enquiry" => {
                                 "enquiryNumber" => 132361,
-                                "externalSystemReference" => "2939061"
                             }
                         },
                         "fmsReport" => {
+                            "externalId" => 2939061,
                             "status" => {
                                 "state" => "Action scheduled",
                                 "label" => "Assessed - scheduling a repair within 5 Working Days"
@@ -189,10 +189,10 @@ $lwp->mock(request => sub {
                             "statusCode" => "3201",
                             "enquiry" => {
                                 "enquiryNumber" => 132361,
-                                "externalSystemReference" => "2939061"
                             }
                         },
                         "fmsReport" => {
+                            "externalId" => 2939061,
                             "status" => {
                                 "state" => "Not responsible",
                                 "label" => "Not Surrey CC's responsibility"
@@ -211,7 +211,6 @@ $lwp->mock(request => sub {
                             "logNumber" => 2,
                             "statusCode" => "2000",
                             "job" => {
-                            "jobNumber" => 569276
                             }
                         },
                         "fmsReport" => {